Bug 10731 - WAV convert to LAME (MP3) fails
: WAV convert to LAME (MP3) fails
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Transcoding
: 7.4.0
: PC Windows XP
: P4 normal (vote)
: 7.4.0
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-16 13:22 UTC by James Richardson
Modified: 2009-10-05 14:27 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
396 (173.17 KB, application/octet-stream)
2009-01-16 15:44 UTC, James Richardson
Details
398 (41.68 KB, application/octet-stream)
2009-01-16 15:44 UTC, James Richardson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Richardson 2009-01-16 13:22:21 UTC
when WAV is forced to transcode to LAME > MP3 noise is heard as out put.

Happens on all players

Lame 3.96.1 installed on XP / Vista
Comment 1 Andy Grundman 2009-01-16 14:57:23 UTC
This fixes it.  Please make sure to test on a PPC Mac as well.  And test with multiple versions of LAME.

Also test AIFF -> MP3 which has a similar convert line.

--- convert.conf	(revision 48800)
+++ convert.conf	(local)
@@ -87,7 +87,7 @@
 
 wav mp3 * *
 	# IFB:{BITRATE=-B %B}D:{RESAMPLE=--resample %D}
-	[lame] --silent -q $QUALITY$ $RESAMPLE$ -v $BITRATE$ $FILE$ -
+	[lame] --silent -q $QUALITY$ $RESAMPLE$ -v $BITRATE$ $-x$ $FILE$ -
 
 aif mp3 * *
 	# IFB:{BITRATE=-B %B}D:{RESAMPLE=--resample %D}
Comment 2 Andy Grundman 2009-01-16 14:58:25 UTC
Change 24695.
Comment 3 James Richardson 2009-01-16 15:42:57 UTC
Windows Vista
3.96.1 WAV playback is fine (with patch)
3.98.2 WAV fails to play (with - w/o patch)
Comment 4 James Richardson 2009-01-16 15:44:14 UTC
Created attachment 4664 [details]
396
Comment 5 James Richardson 2009-01-16 15:44:29 UTC
Created attachment 4665 [details]
398
Comment 6 Spies Steven 2009-01-16 15:52:40 UTC
(In reply to comment #3)
> Windows Vista
> 3.96.1 WAV playback is fine (with patch)

Just wanted to note that this was with 16/44.1.  I suspect the patch will not work with other rates.

Alan, do we not send the wav header to lame when transcoding?
Comment 7 Alan Young 2009-01-17 08:21:27 UTC
This is all part of the problem addressed by bug 10026. For 7.3.2 we could resolve this removing the 'I' from the capabilities line and probably also the $-x$ from the transcoder (again). We would need to remember to put back the 'I' when the fix for 10026 is applied.
Comment 8 Blackketter Dean 2009-01-19 08:26:58 UTC
I don't see why this is a major bug, or even why it would be open for 7.3.2.  

Move it back if you disagree...
Comment 9 Alan Young 2009-03-10 01:41:03 UTC
Fixed with the changes in bug 10026 and change 25457.
Comment 10 James Richardson 2009-10-05 14:27:09 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.