Bugzilla – Bug 10646
Playlists with zero or one entry cannot be deleted using Player UI
Last modified: 2009-10-05 14:31:00 UTC
A playlist with zero or one entries does not offer a delete option on the controller or SB3. It can be deleted using the web UI. (such playlists are sometimes created by plugins like syncoptions).
What is a playlist with zero entries?
They happen - I've seen syncoptions make one. you can make one by creating a playlist (save from the web UI) and then deleting all its entries and saving it again.
I've no recollection of a delete option on the player UI, but I can see the problem in the Controller case.
Created attachment 4929 [details] rough patch Here is a rough patch that seems to cover at least the empty playlist. I'll have to create a single-item playlist to test more. Also, haven't tested that the delete actually works, or that there are no side-effects from allowing the query processing to continue in the 0 or 1 cases. There must have been some reason to do the checks currently in place, that I'm partially bypassing in this patch.
Created attachment 4932 [details] working patch This patch works by adding delete as an option for empty playlists. Adding as a favourite is not given. Single-track playlists still get the favourites option along with the delete option. The remaining problem is that I've noticed some playlists don't show the "add to favorites" option at the end. It's in the result, but for some reason, doesn't show on the controller. Single item lists work, and a VERY long list works. other lists don't seem to.
Created attachment 4936 [details] working patch with favorites for all had to use _fixCount in order to get the favorites item to show up all the time. Not that I understand exactly how that routine works, but it was being used for other playlist queries :)
We are now planning to make a 7.3.3 release. Please review your bugs (all marked open against 7.3.3) to see if they can be fixed in the next few weeks, or if they should be retargeted for 7.4 or future. Thanks!
this one works for me, so I'm happy to commit. I'd be reassured if Ben/Tom/Richard could review and give the go-ahead.
may be related in part to bug 7829
Tom, maybe you could review KDF's change?
punting to Ben to review, since I'm still a SC newbie. Hopefully I won't be that way forever....
Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out. If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it. Thanks.
For some reason Bugzilla did not change the target when I did this yesterday. Or maybe it was me. In either case, I'm trying it again.
I will review.
Patch applied as change 28034.
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server! * SqueezeCenter: 28672 * Squeezebox 2 and 3: 130 * Transporter: 80 * Receiver: 65 * Boom: 50 * Controller: 7790 * Radio: 7790 Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.