Bug 10644 - Artist missing when viewed w/Fab4
: Artist missing when viewed w/Fab4
Status: NEW
Product: SqueezePlay
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh MacOS X 10.5
: -- normal with 2 votes (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-01-10 12:48 UTC by Mike Cappella
Modified: 2011-11-06 23:23 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
fix count (768 bytes, patch)
2009-02-16 01:02 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Cappella 2009-01-10 12:48:38 UTC
I created a small library for testing.  I started with 4 albums from
"3rd Force".  They showed up correctly under Home->Artists on the web
interface and Music Library->Artists on Fab4.

Then I added a compilation album under "Assorted" (which is the
"Various Artists" grouping used by JRMC).  I cleared and rescanned the
library.

After that, the web interface correctly shows two entries under
Artists: "Assorted" and "3rd Force".  But!  Fab4 only shows "Assorted"
under Music Library->Artists, and is missing the "3rd Force" artist. 
It does correctly show all 5 albums under Music Library->Albums.  Genres correctly shows 2 genres, but the genre that corresponds to the missing artist is empty.
Comment 1 Mike Cappella 2009-01-16 09:30:51 UTC
This may be a tough one to crack.  If you need a reproduce case, let me know.

Also, after I added more albums (not VA, which I have as Assorted), the problem disappears.  There's an edge case here.
Comment 2 Michael Herger 2009-01-17 10:31:31 UTC
Do you see the same issue on the player UI or on the Controller?

I'm not sure there's a lot going to happen for this issue before we have the new schema in place.
Comment 3 Mike Cappella 2009-01-17 12:57:01 UTC
The SquezePlay mac player UI shows the same as the controller UI.

Here is a test library (with truncated flacs, totaling about 5.3M).

   http://www.mikecappella.com/dump/testlib-10644.tgz

Set: Group compilation albums together
Set: List albums by band
Set: Treat TPE2 MP3 tag as Album Artist
Set: Various Artists string to "Assorted"

and do a full rescan of everything.

On the web UI, examine Arists, and note that there are 2.  Do the same now on the Controller or SqueezePlay UI.  Note that there is only 1 artist appearing (Assorted).

Note also that one track seems to have a No Genre genre tag (Genres->No Genre->3rd Force->3rd Force->4. The Gift.

Somewhere, the scanner or database management is doing something incorrect.
Comment 4 Michael Herger 2009-02-16 00:38:47 UTC
Mike - do you encounter problems scrolling through your full list of artists? How many of them do you have?

Ben - this looks like one more occurence of a badly "fixed" count.
Comment 5 Michael Herger 2009-02-16 00:39:18 UTC
artists 0 100 id%3A10 artist%3AAssorted id%3A1 artist%3A3rd%20Force count%3A1

The full list is returned, but the count is wrong.
Comment 6 Michael Herger 2009-02-16 01:02:37 UTC
Created attachment 4818 [details]
fix count

Ben - _fixCount() fails in this case, because we only have 1 "real" artist, but _fixCount will only change the count if it's >1. You might know better than I do why this is the case. The attached patch might fix this.

That said I think the behaviour should have been correct with more than one artist. Mike - can you reproduce this issue with any number of artists?
Comment 7 Mike Cappella 2009-07-17 14:28:15 UTC
I just saw the questions asked below; don't know why I never noticed or received the notification of comments here.

Michael's question 1:
"Mike - do you encounter problems scrolling through your full list of artists?
How many of them do you have?"

Well, I don't think there are problems with scrolling.  In the test case I had given, I only had a few artists.  I am still able to reproduce the problem (I just tried it) with < 6 artists (1 Multiple Artists, 1 No Artist, and 4 specific artists).

Michael's question 2:
"Mike - can you reproduce this issue with any number of artists?"

I'm not sure about any number, but as I add albums w/different artists, there is no change (still reproducible).
Comment 8 Mike Cappella 2009-07-17 15:00:39 UTC
Perhaps this bug is the same as that mentioned in this forum thread:

http://forums.slimdevices.com/showthread.php?t=65573

I don't want to comment there on this bug since this bug mentions Fab4.
Comment 9 Jim McAtee 2009-07-17 17:03:08 UTC
This is easy to duplicate. When you have only one (album) artist and the rest of the library consists of compilation albums, then only the VA artist is shown in the artist list on Fab4. The artist list appears to correct itself when a second artist is added to the library.

I see the same bug when browsing Genres. If there's only the VA artist and one other artist in a genre, then only the VA artist appears.
Comment 10 Ben Klaas 2009-08-26 07:46:42 UTC
this is an administrative shuffle on priority fields to help make better judgment on the top end of the priority list. P4->P5, P3->P4, and P2->P3.
Comment 11 Chris Owens 2010-03-08 11:32:57 UTC
Moving lower-priority bugs to next target
Comment 12 Ben Klaas 2011-01-13 14:58:00 UTC
If this bug still is an issue, I don't think it's mine to fix
Comment 13 Alan Young 2011-11-06 23:23:58 UTC
Unassigned bugs cannot have a priority.