Bugzilla – Bug 10516
None screensaver does not activate when stopped.
Last modified: 2009-09-08 09:14:14 UTC
Set "Screensaver when playing" to "Analog VU Meter" and "Screensaver when stopped" to "None". Play a track. Once the track completes, the player is stopped. However, a motionless VU meter continues to be displayed. I would expect the "None" screensaver to take over and return me to the menus, as would happen if I pressed one of the arrow keys on the remote control.
Created attachment 4531 [details] Pop old screensaver mode when saver changes to "nosaver". The attached patch seems to do the trick.
Created attachment 4532 [details] suggested patch I think there are other cases too - here's a suggested patch which hopes to cover all cases when the screensaver switches from now playing to idle
Kevin - does this patch help with your screensaver issues? (and does it look right?)
Triode, You patch does address one of the things I've been seeing (screensaver not switching to the idle saver when playback naturally stops). However, the report is a specific case of "none" being the screensaver setting. Strictly speaking, "none" is supposed to mean "do nothing at all". Thus, what you get when using the analog VU for playback should be a static VU when IDLE. That is the design. The idea of this report seems to be to change this behaviour such that the "none" be based on the state of the player prior to playback. This way, when the player stops, the analog VU would go away, as would the Now Playing screen if that is the "while playing" screensaver. I'm not really a fan of special cases myself. They just end up being a pain later on. This is more a matter for Dean to decide what the final behaviour should be. To my mind "none" already does what it's supposed to do: nothing at all.
Well it depends what we define "none" to mean. It does seem slightly counter intuative without it, but perhaps thats by design.. Considering the default setting case - as most people will have this - do we want the screen to stay on now playing or go back to the browsed menu when playback stops?
I think that when the player is stopped, the idle saver should kick in and display the menu where the user last left off. If they want the VU meters to stay up, they can use the VU meter screensaver as their idle saver.
Right - so the patch does this - I'd check into 7.4 but I can't commit it at present...
Great, thanks!
added to 7.4 in change 24467