Bug 10510 - playlistJumpCommand has lost its showBriefly
: playlistJumpCommand has lost its showBriefly
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 7.3.1
: PC Windows Vista
: -- normal (vote)
: 7.x
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-30 16:40 UTC by Adrian Smith
Modified: 2009-07-31 10:33 UTC (History)
0 users

See Also:
Category: ---


Attachments
propsed patch (2.72 KB, patch)
2008-12-30 17:33 UTC, Adrian Smith
Details | Diff
Alternate patch for up-to-date playing song (823 bytes, patch)
2009-01-04 05:01 UTC, Alan Young
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Smith 2008-12-30 16:40:43 UTC
showBriefly for jumping between tracks has been lost with the new streaming code - its there by commented out (and also there are some returns which miss it)

The more serious issue is that $client->currentSongLines assumes is can get the currently playing song from Slim::Player::Playlist::song($client) soon as it is skipped - this doesn't look like it is true now?

I think this should be fixed as the showBriefly was useful for all but users of transporters with extended text (and for them the display now lags by a second or so)

So can we set Playlist::song earlier?
Comment 1 Adrian Smith 2008-12-30 17:33:34 UTC
Created attachment 4529 [details]
propsed patch

Suggested patch - this looks to fix the stale track information during skips.  I guess the question is whether it is right to keep the old calls with the latest data but leave StreamingController to have a songqueue of 2 with the first track completed but still considered the one to be playing.
Comment 2 Alan Young 2009-01-04 05:01:11 UTC
Created attachment 4540 [details]
Alternate patch for up-to-date playing song

How about the following alternate patch for the up-to-date-ness of playingSong?

The rest of the patch looks ok.
Comment 3 Adrian Smith 2009-01-04 05:19:44 UTC
Yes that works - committed as change 24482
Comment 4 Adrian Smith 2009-01-17 10:22:24 UTC
Fix was not working correctly on transporter due to api change - change 24710 should correct this.
Comment 5 James Richardson 2009-01-22 09:58:58 UTC
Fixed - Closed Message (SC)

This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 6 James Richardson 2009-01-22 13:54:48 UTC
Correction: SqueezeCenter version is 7.3.2
Comment 7 Chris Owens 2009-07-31 10:33:51 UTC
Reduce number of active targets for SC