Bug 10452 – Bogus " (Disc 1)" suffix appended to single-disc album titles of FLAC tracks ripped by dBpoweramp CD Ripper.

Bug 10452 - Bogus " (Disc 1)" suffix appended to single-disc album titles of FLAC tracks ripped by dBpoweramp CD Ripper.

Summary:

Bogus " (Disc 1)" suffix appended to single-disc album titles of FLAC tracks ...

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Scanner
Version:	7.3.1
Platform:	PC Windows XP

Importance:	-- normal with 1 vote (vote)
Target Milestone:	7.x
Assigned To:	Michael Herger

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-12-24 02:20 UTC by D D
Modified:	2009-07-31 10:33 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description D D 2008-12-24 02:20:20 UTC

SqueezeCenter displays album titles of all single-disc albums ripped to FLAC track files by dBpoweramp CD Ripper R13.1 (http://www.dbpoweramp.com/) with a bogus " (Disc 1)" suffix.  The " (Disc 1)" suffix should not be added.

This bug occurs in Slim/Music/Info.pm::addDiscNumberToAlbumTitle() because each track's album's TITLE and DISC are set, but not its DISCC.  dBpoweramp CD Ripper sets "Album", "DiscNumber", and "TotalDiscs" FLAC tags for each FLAC track.  The SqueezeCenter code uses the "Album" FLAC tag as the album's TITLE.  Slim/Formats/FLAC.pm::%tagMapping maps the "DiscNumber" FLAC tag to the album's DISC.  However, the FLAC "TotalDiscs" tag is never mapped to the album's DISCC.

It would be helpful to map the "TotalDiscs" FLAC tag to the DISCC tag.  E.g., add something like

my %tagMapping = (
    # ...

    # for dBpoweramp CD Ripper
    'TOTALDISCS'                => 'DISCC',
);

to Slim/Formats/FLAC.pm::%tagMapping.

Comment 1 James Richardson 2008-12-29 15:49:49 UTC

Michael: would this one be yours to address? or someone else

Comment 2 David A. Gordon 2008-12-30 13:51:41 UTC

I'm having this problem too; I'll add that there doesn't seem to be *any* commonly used FLAC tagger out there that writes the total number of discs to DISCC. TOTALDISCS seems like the de facto standard; at the very least, SC should recognize it. This seems like a pretty trivial thing to fix.

Comment 3 Michael Herger 2009-01-06 08:34:12 UTC

change 24533 - thanks!

Comment 4 James Richardson 2009-01-16 10:31:19 UTC

Fixed in SqueezeCenter 7.3.2 r24679 for FLAC 

Still an issue with OGG/OGA when discnumber = 1

Comment 5 James Richardson 2009-01-16 10:34:05 UTC

forgot to add, that totaldiscs = 1 as well

when both of these tags =1 we should not show (Disc 1) in WEB UI

Comment 6 Michael Herger 2009-01-18 23:22:43 UTC

James/Steven - could you please provide a sample file to reproduce this issue?

Comment 7 James Richardson 2009-01-19 09:16:06 UTC

James to open new bug specific to OGG file type

Comment 8 James Richardson 2009-01-22 09:58:53 UTC

Fixed - Closed Message (SC)

This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 9 James Richardson 2009-01-22 13:54:43 UTC

Correction: SqueezeCenter version is 7.3.2

Comment 10 Chris Owens 2009-07-31 10:33:45 UTC

Reduce number of active targets for SC