Bug 10390 – 'pref' command & query too strict about pref names

Bug 10390 - 'pref' command & query too strict about pref names

Summary:

'pref' command & query too strict about pref names

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	CLI
Version:	7.4.0
Platform:	PC Other

Importance:	-- normal with 1 vote (vote)
Target Milestone:	7.4.0
Assigned To:	Michael Herger

URL:	http://forums.slimdevices.com/showthr...
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-12-18 21:46 UTC by Peter Watkins
Modified:	2009-10-05 14:28 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
patch that fixes both query and set modes of 'pref' command (1.06 KB, patch) 2008-12-18 21:46 UTC, Peter Watkins	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Peter Watkins 2008-12-18 21:46:52 UTC

Created attachment 4475 [details]
patch that fixes both query and set modes of 'pref' command

The 'pref' CLI command, both in query and set/command mode, is supposed to accept preference names in the format $namespace:$prefname. But the regexp for parsing $namespace:$prefname only allows $prefname to contain letters and numbers. Preference names like 'macro-Boom-preset_6', while legal in Perl code, are not usable with the 'pref' CLI commands.

Comment 1 James Richardson 2008-12-19 10:24:46 UTC

Michael: can you review Peters patch.

Comment 2 Michael Herger 2009-01-06 00:47:14 UTC

change 24527 - applied in 7.4 branch

Comment 3 James Richardson 2009-10-05 14:28:30 UTC

This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.