Bug 10382 - Possible changes to convert.conf
: Possible changes to convert.conf
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Transcoding
: 7.3.0
: All All
: P2 normal (vote)
: 7.3.3
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-18 09:45 UTC by Alan Young
Modified: 2009-06-17 09:36 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2008-12-18 09:45:50 UTC
From bug 10335. Steven said:

Looks to me like a couple of the lines in convert.conf can be cleaned up.  I suggest the following:

Change:
mov mp3 * *
	# FRB:{BITRATE=-B %B}
	[mov123] $FILE$ | [lame] --resample 44100 --silent -q $QUALITY$  $RESAMPLE$-v $BITRATE$ -r --big-endian - -
To:
mov mp3 * *
	# FRB:{BITRATE=-B %B}D:{RESAMPLE=--resample %D}
	[mov123] $FILE$ | [lame] --silent -q $QUALITY$ $RESAMPLE$ -v $BITRATE$ -r --big-endian - -

Change:
ape mp3 * *
	# FB:{BITRATE=-B %B}D:{RESAMPLE=--resample %D}
	[mac] $FILE$ - -d | [lame] --resample 44100 $-x$ --silent -q $QUALITY$ $RESAMPLE$ -v $BITRATE$ - -
To:
# FB:{BITRATE=-B %B}D:{RESAMPLE=--resample %D}
	[mac] $FILE$ - -d | [lame] --silent -q $QUALITY$ $RESAMPLE$ -v $BITRATE$ - -

Alan, what do you think?
Comment 1 Jim McAtee 2008-12-19 13:23:58 UTC
Since LAME produces 128kbps CBR mp3 by default, I would suggest the following would be more consistent:

BITRATE=-v -B %B

A couple others:

I would suggest using the long versions of all Flac options, which are more self-documenting.  Instead of

-dcs

use

--decode --stdout --silent (or --totally-silent)

There are a number of redundant -s (--silent) options used along with --totally-silent.  For example

wma flc * *
	# F:{PATH=%f}R:{PATH=%F}
	[wmadec] -w $PATH$ | [flac] -cs --totally-silent --compression-level-0 -

In this case -cs means "--stdout --silent", but --totally-silent supersedes the --silent option.  So all the "-cs --totally-silent" could be changed to:

--stdout --totally-silent

Another inconsistency with respect to Flac options, is the use of = signs for option values:

flc wav * *
	# FT:{START=--skip=%t}U:{END=--until=%v}
	[flac] -dcs --force-raw-format --endian=little --sign=signed $START$ $END$ -- $FILE$

vs.:

mov flc * *
	# FR
	[mov123] $FILE$ | [flac] -cs --totally-silent --compression-level-0 --endian big --sign signed --channels 2 --bps 16 --sample-rate 44100 -



Comment 2 Alan Young 2008-12-23 09:49:12 UTC
I have fixed up the mov mp3 rule in a slightly different way. I do not really know what to do with the ape mp3 one.
Comment 3 Alan Young 2009-01-09 05:41:31 UTC
Fixed in other changes for 7.3.2 and 7.4
Comment 4 Spies Steven 2009-04-30 11:35:12 UTC
Verified fixed with SqueezeCenter Version: 7.3.3 - 26228
Comment 5 James Richardson 2009-06-17 09:36:02 UTC
This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html 

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.