Bug 10371 - Bright white LED does not go off at end of play
: Bright white LED does not go off at end of play
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Streaming From SlimServer
: 7.3.0
: Other Ubuntu Linux
: -- normal (vote)
: 7.3.3
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-17 11:53 UTC by Jeffrey Barish
Modified: 2009-06-17 09:36 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeffrey Barish 2008-12-17 11:53:58 UTC
I play a track using CLI.  The LED on the SBR is bright white.  If I issue the stop command, the LED changes to dim white.  If I play to the end, the mode changes to stop but the LED does not change to dim white.
Comment 1 James Richardson 2008-12-17 12:31:30 UTC
Ross, Can you investigate this one
Comment 2 Ross Levine 2008-12-17 14:18:31 UTC
This doesn't seem to be specific to CLI, although it is easily reproduced as mentioned by Jeffrey. I was also able to reproduce this using web ui. 7.3.1 - 24324.

Michael, is this your bug? 
Comment 3 Michael Herger 2008-12-17 22:48:26 UTC
sounds like a firmware issue to me. Felix?
Comment 4 Felix Mueller 2008-12-18 00:43:24 UTC
Nope, not firmware, it's all handled from within SC. Seems like neither stop() nor pause() in Player/Reciever.pm is called in such a case.
Comment 5 Michael Herger 2008-12-18 01:15:14 UTC
Alan - might this be some missed event in the streaming code?
Comment 6 Felix Mueller 2008-12-18 01:38:03 UTC
stop() or pause() functions of Receiver.pm are never called if a song just plays out. Also stop() or pause() functions of parent class i.e. Squeezebox2.pm are never called, same is true for Squeezebox.pm, Player.pm or Client.pm.

Interestingly the play/pause button on the webinterface changes back to play when a song just plays out. I have no idea, where it get the information from though.

Comment 7 Alan Young 2008-12-18 09:52:51 UTC
Is this a regression from 7.2 or has it always been that way?
Comment 8 Jeffrey Barish 2008-12-18 10:13:00 UTC
I first noticed it around the time I upgraded to SC 7.3.  However, the SBR upgrades its firmware automatically, so it's possible that I am confusing the real culprit.  If Felix is right that the problem can't be in the firmware (which otherwise seemed to be a plausible theory), then I believe that the problem is a regression from 7.2.
Comment 9 Ross Levine 2008-12-18 12:01:27 UTC
(In reply to comment #7)
> Is this a regression from 7.2 or has it always been that way?
> 

Yes. I just tried this with 7.2 and it is not reproducible. 
Comment 10 James Richardson 2008-12-19 08:01:42 UTC
Changing target to next release
Comment 11 Keith 2009-01-08 03:21:09 UTC
I have found the same problem after updating to 7.3
Comment 12 Felix Mueller 2009-01-08 09:32:03 UTC
Alan: Any idea why pause() or stop() functions are not called?
Comment 13 Alan Young 2009-01-08 09:33:57 UTC
Why would they be? The player has just reported that it has stopped. No need to stop it some more.
Comment 14 Felix Mueller 2009-01-08 09:51:54 UTC
Well, see comment #6, they have been called in the past.

Are you saying that was incorrect? What is the new way to get this events?
Comment 15 Alan Young 2009-01-08 09:57:10 UTC
There isn't one. I guess we will have to build something. I'll take this.
Comment 16 Alan Young 2009-01-16 05:25:02 UTC
Change 24685.
Comment 17 Anoop Mehta 2009-04-23 12:45:43 UTC
Verified fix in 7.3.3 r26187
Comment 18 Anoop Mehta 2009-04-23 12:51:57 UTC
sorry,

Comment 17 verification was with XP. 

Verified on Ubuntu 7.3.3 r25766
Comment 19 James Richardson 2009-06-17 09:36:01 UTC
This bug has been fixed in the 7.3.3 release version of SqueezeCenter!

If you haven't already. please download the new version from http://www.logitechsqueezebox.com/support/download-squeezecenter.html 

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.