Bug 1037 – Server crash on parsing cue file

Bug 1037 - Server crash on parsing cue file

Summary:

Server crash on parsing cue file

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Misc
Version:	6.0.0
Platform:	PC Linux (other)

Importance:	P2 major (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-03-11 05:08 UTC by Caleb Crome
Modified:	2011-03-16 04:19 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Stdout of slimserver when crashing (1.77 KB, text/plain) 2005-03-11 23:24 UTC, Caleb Crome	Details
crazy .cue file. (791 bytes, text/plain) 2005-03-11 23:26 UTC, Caleb Crome	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Caleb Crome 2005-03-11 05:08:31 UTC

The server crashed -- I don't know why, but here is a dump that was left on my
screen:

2005-03-09 00:49:01.8635 No URL specified for updateOrCreate
Use of uninitialized value in concatenation (.) or string at /usr/local/slimserv
                                                             
er/Slim/Utils/Misc.pm line 831.
2005-03-09 00:49:01.8644 2005-03-09 00:49:01.8657 Backtrace:

   frame 0: Slim::DataStores::DBI::DBIStore::updateOrCreate (/usr/local/slimserv
                                                             
er/Slim/Formats/Parse.pm line 285)
   frame 1: Slim::Formats::Parse::parseCUE (/usr/local/slimserver/Slim/Formats/P
                                                              arse.pm line 427)
   frame 2: Slim::Formats::Parse::readCUE (/usr/local/slimserver/Slim/Formats/Pa
                                                              rse.pm line 52)
   frame 3: Slim::Formats::Parse::parseList (/usr/local/slimserver/Slim/Utils/Sc
                                                              an.pm line 583)
   frame 4: Slim::Utils::Scan::readList (/usr/local/slimserver/Slim/Utils/Scan.p
                                                              m line 204)
   frame 5: Slim::Utils::Scan::addToList_run (/usr/local/slimserver/Slim/Utils/S
                                                            cheduler.pm line 95)
   frame 6: Slim::Utils::Scheduler::run_tasks (./slimserver.pl line 553)
   frame 7: main::idle (./slimserver.pl line 512)
   frame 8: main::main (./slimserver.pl line 1061)

Can't call method "secs" on an undefined value at /usr/local/slimserver/Slim/For
                                                              mats/Parse.pm line
291.

Comment 1 KDF 2005-03-11 15:33:44 UTC

This crash is due to the server finding a .CUE file, and something in it would
seem to be invalid.  If you can recreate this crash with --d_parse turned on
from server settings->debugging, or from the command line, that would locate
which one.  Please attach that CUE file to this report.

Comment 2 Caleb Crome 2005-03-11 23:24:28 UTC

Created attachment 325 [details]
Stdout of slimserver when crashing

Comment 3 Caleb Crome 2005-03-11 23:26:28 UTC

Created attachment 326 [details]
crazy .cue file.

This is the file that seems to cause the crash.

Comment 4 KDF 2005-03-12 00:39:32 UTC

thanks.  it seems that the server is expecting a cue file to properly enclose
the filename in quotes (").  As a short term workaround, you can probably avoid
the crash by editing this cue file to put both filenames in quotes. I dont know
offhand if quotes are a requirement of CUE sheet specs, or just a feature of
'nice' CUE sheets.

What programe were you using to create these CUE files?

Comment 5 Dan Sully 2005-03-12 00:46:39 UTC

I've checked in a workaround as subversion change 2443.

It allows the cue sheet to not have quotes around the filename.