Bug 10355 – Negative replay gain peak prevents playing

Bug 10355 - Negative replay gain peak prevents playing

Summary:

Negative replay gain peak prevents playing

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Audio
Version:	7.3.1
Platform:	PC Debian Linux

Importance:	-- major (vote)
Target Milestone:	7.x
Assigned To:	Andy Grundman

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-12-16 16:29 UTC by Blah
Modified:	2009-07-31 10:33 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Blah 2008-12-16 16:29:32 UTC

[08-12-17 01:19:32.7846] Slim::Control::Request::execute (1889) Error: While trying to run function coderef [Slim::Control::Commands::playlistJumpCommand]: [Can't take log of -0.001953 at /usr/share/perl5/Slim/Player/ReplayGain.pm line 181.

Changing if ($peak) to if($peak > 0) fixes the problem.

mp3gain on file :
Recommended "Track" dB change: 0.525000          
Recommended "Track" mp3 gain change: 0
Max PCM sample at current gain: 15555.231744
Max mp3 global gain field: 205
Min mp3 global gain field: 112


Recommended "Album" dB change for all files: -0.205000
Recommended "Album" mp3 gain change for all files: 0

SqueezeCenter version is :  squeezecenter  7.3.1~24324  (debian package)

Comment 1 Andy Grundman 2008-12-17 06:40:23 UTC

I'll fix.

But how did you end up with a peak value that's negative?

Comment 2 Andy Grundman 2008-12-17 06:42:13 UTC

Fixed in change 24330.

Comment 3 Blah 2008-12-17 14:45:30 UTC

I don't know. I just ran mp3gain -a on the album. Maybe a bug in it ?

Comment 4 James Richardson 2008-12-19 07:40:36 UTC

This appears to be addressed in  SqueezeCenter 7.3.1 r24367

Can you confirm that version is working for you?

Comment 5 Blah 2008-12-19 16:50:04 UTC

It is.

Comment 6 James Richardson 2008-12-22 11:37:02 UTC

This bug has been fixed in the 7.3.1 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 7 Chris Owens 2009-07-31 10:33:31 UTC

Reduce number of active targets for SC