Bug 10352 - Invalid range limit on DNS server address
: Invalid range limit on DNS server address
Status: CLOSED FIXED
Product: SqueezePlay
Classification: Unclassified
Component: UI
: unspecified
: PC SuSE Linux
: P1 normal (vote)
: 7.4.0
Assigned To: Felix Mueller
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-16 05:20 UTC by Fedder Skovgaard
Modified: 2009-10-05 14:26 UTC (History)
5 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fedder Skovgaard 2008-12-16 05:20:53 UTC
Server: SqueezeCenter 7.3-2482 running on openSUSE 10.3 x86/32-bit
Wireless access point: Linksys WAP 54G

Network topology: 
The box running SqueezeCenter (heimdal) acts as a NAT / router for the LAN. Using the stock dhcpd on the private LAN for the address range: 192.168.0.0/24

ISP: Dansk Bredbaand (www.dbnet.dk)

Problem is that the Controller would not accept the DHCP offer from the server, when the offer included a DNS server with the following address: 208.067.222.222 (OpenDNS primary server)

Changing to the default DNS server for dbnet.dk (82.143.255.20) solved the problem.

Curiously, trying to specify a static IP address through the controller GUI during setup, it was not possible to enter the IP address of the OpenDNS server, since it wasn't possible to select a value higher than '1' as the first digit in the first group of the IP address, which is clearly an error.

Best regards,
/Fedder
Comment 1 Chris Owens 2008-12-22 10:06:44 UTC
Should be possible to simulate this network.  Richard notes that if you have 199 you can't make the first digit a '2', but if you have 109 you can.  
Comment 2 Fedder Skovgaard 2008-12-28 16:19:27 UTC
It's relatively easy to create a test scenario, if you can construct a mock-up of a home-lan with a wireless router acting as gateway, or (as I do) use a Linux box as router / NAT device, and attach a wireless access point to that.

The key point is to instruct the DHCP server on the NATed network to use the DNS servers from OpenDNS, which are free of use globally, Ref:
https://www.opendns.com/smb/start

If you're using a Linux box running dhcpd, you can add the following line to your /etc/dhcpd.conf file:
# Use OpenDNS servers
#option domain-name-servers 208.67.222.222, 208.67.220.220;

After that, restart dhcpd, and watch /var/log/messages and conclude that the controller never sends the final DHCPACK, following the normal DHCPDISCOVER / DHCPOFFER / DHCPREQUEST sequence.

Unless, of course you change the DHCP server to offer dns servers with "suitable" addresses...

None of this, by the way is actually related to this particular flavor of Linux, so I wonder if the OS for this bug should be changed to "All".
Comment 3 Jim McAtee 2008-12-28 22:34:45 UTC
(In reply to comment #1)
> Richard notes that if you have 199 you can't make the first digit a 
> '2', but if you have 109 you can.  

That's just a dumb input validation algorithm, then.  People enter numbers from left to right and (like the bug reporter) won't have a clue why they can't enter a 2.  Many people will be changing from 192.168..., so will be stuck from the get go.  The algorithm needs to validate the whole octet only after the cursor moves off the three digits, not before.  It can safely limit the first digit to 1 & 2, but can't keep you from entering a 2 based on the second two digits.

Comment 4 Chris Owens 2009-03-16 09:43:30 UTC
We are now planning to make a 7.3.3 release.  Please review your bugs (all marked open against 7.3.3) to see if they can be fixed in the next few weeks, or if they should be retargeted for 7.4 or future.

Thanks!
Comment 5 Chris Owens 2009-03-30 17:19:43 UTC
Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out.  If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it.

Thanks.
Comment 6 Blackketter Dean 2009-07-22 08:39:51 UTC
Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the single original product.
Comment 7 Wadzinski Tom 2009-07-30 09:47:22 UTC
Tom, confirm
Comment 8 Wadzinski Tom 2009-08-03 11:59:58 UTC
Sounds more like Felix's domain
Comment 9 SVN Bot 2009-08-23 03:30:35 UTC
 == Auto-comment from SVN commit #7221 to the jive repo by felix ==
 == https://svn.slimdevices.com/jive?view=revision&revision=7221 ==

Bug: 10352 +2 
Description: Fix range limit when entering ip address allowing to enter / correct from left to right.
Comment 10 Felix Mueller 2009-08-23 03:33:55 UTC
Hey Tom: hmm, it's not, but I think I found a solution for it anyway. Hopefully I did not break anything else.

Fixed in r7221
Comment 11 James Richardson 2009-10-05 14:26:30 UTC
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server!
    * SqueezeCenter: 28672
    * Squeezebox 2 and 3: 130
    * Transporter: 80
    * Receiver: 65
    * Boom: 50
    * Controller: 7790
    * Radio: 7790  

Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes

If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.