Bug 10315 – MusicIP Playlist names with non-ASCII characters need sanitizing on Windows

Bug 10315 - MusicIP Playlist names with non-ASCII characters need sanitizing on Windows

Summary:

MusicIP Playlist names with non-ASCII characters need sanitizing on Windows

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	MusicIP
Version:	7.3.0
Platform:	PC Windows XP

Importance:	P2 normal with 2 votes (vote)
Target Milestone:	7.x
Assigned To:	Michael Herger

URL:	http://forums.slimdevices.com/showthr...
Keywords:	charset_issues

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-12-13 11:31 UTC by Moonbase
Modified:	2009-07-31 10:33 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Importer.pm diff against SC 7.3-24282 (928 bytes, patch) 2008-12-13 11:31 UTC, Moonbase	Details \| Diff
Newly uploaded unified diff against SC 7.3-24282 (1.51 KB, patch) 2008-12-13 14:48 UTC, Moonbase	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Moonbase 2008-12-13 11:31:31 UTC

Created attachment 4428 [details]
Importer.pm diff against SC 7.3-24282

SC 7.3-24282

MusicIP playlist names are returned as UTF-8 by the MusicIP API even on Windows. In case they contain non-ASCII characters, these need to be sanitized for correct display in SC.

See forum thread:
7.3r24282: Sanitizing MusicIP Playlist names with non-ASCII characters (Windows)
http://forums.slimdevices.com/showthread.php?t=56372

Requires a change in MusicIP plugin’s "Importer.pm" which I have done and attached. Cross-check on Linux and MacOS, please.

Please verify and integrate these changes into the MusicIP plugin.

Comment 1 Moonbase 2008-12-13 14:48:47 UTC

Created attachment 4435 [details]
Newly uploaded unified diff against SC 7.3-24282

First diff was normal mode, re-uploaded a unified diff.

Comment 2 Michael Herger 2008-12-15 09:34:59 UTC

change 24304 - I've checked in a bunch of changes for MIP import/mix/mood/playlist handling related to non-latin stuff. Please give it a try. Thanks!

Comment 3 James Richardson 2008-12-22 11:36:56 UTC

This bug has been fixed in the 7.3.1 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Comment 4 Chris Owens 2009-07-31 10:33:21 UTC

Reduce number of active targets for SC