Bug 10314 - Tracks/Albums/Artists not mixable if non-ASCII chars in file path
: Tracks/Albums/Artists not mixable if non-ASCII chars in file path
Status: RESOLVED DUPLICATE of bug 9772
Product: Logitech Media Server
Classification: Unclassified
Component: MusicIP
: 7.3.0
: PC Windows XP
: P2 normal with 3 votes (vote)
: 7.x
Assigned To: Michael Herger
http://forums.slimdevices.com/showthr...
: charset_issues
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-12-13 11:23 UTC by Moonbase
Modified: 2009-07-31 10:33 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
Importer.pm diff against SC 7.3-24282 (928 bytes, patch)
2008-12-13 11:23 UTC, Moonbase
Details | Diff
Newly uploaded unified diff against SC 7.3-24282 (1.51 KB, patch)
2008-12-13 14:47 UTC, Moonbase
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Moonbase 2008-12-13 11:23:45 UTC
Created attachment 4427 [details]
Importer.pm diff against SC 7.3-24282

SC 7.3-24282

When using both the Music Folder and have MusicIP only check for mixable status on Windows installations, any tracks containing non-ASCII characters in their file path will not be mixable (API request fails due to wrong file path given).

See forum thread:
7.3r24282: Tracks not mixable (MusicIP) if non-ASCII chars in file path (Windows)
http://forums.slimdevices.com/showthread.php?t=56330

Requires a slight change in the MusicIP plugin’s "Importer.pm" which I have done and attached. Cross-check on Linux and MacOS, please.

Please verify and integrate these changes into the MusicIP plugin.
Comment 1 Moonbase 2008-12-13 14:47:11 UTC
Created attachment 4434 [details]
Newly uploaded unified diff against SC 7.3-24282

The other diff was in normal mode, sorry.
Comment 2 Markus Schiegl 2008-12-14 03:16:12 UTC
I've applied the patch from comment #1 and at a first glance it looks good (in other words: it didn't break) on my linux-gentoo-utf8 system. A wipe&full-scan recognized all my tracks again and set them to "mixable". New mixes are possible, too.

Today i'm in "simple mode" so i didn't cross check the logs nor tried to understand the code ;-)

btw. i'm using the linux headless MIP service so i can't check the playlist and moods functionality - still waiting for MusicIP to port at least moods to linux.
Comment 3 Moonbase 2008-12-14 03:58:51 UTC
OFF-TOPIC, re MusicIP Headless:

Markus, you might want to check out one of the »newer« headless versions. If I understood Wendell (of MusicIP) correctly, they’ve introduced a "-data=folder" switch, hopefully not only for the Windows version. This should point to the folder containing the "Mood" and "dj" folders. I reckon is was in one of the betas, 1.9b6 or the like.
Comment 4 Michael Herger 2008-12-15 01:28:05 UTC
I'm going to address several charset related issues in the next few days. Thanks a lot for the patch!
Comment 5 Michael Herger 2008-12-15 06:32:54 UTC

*** This bug has been marked as a duplicate of bug 9772 ***
Comment 6 Chris Owens 2009-07-31 10:33:20 UTC
Reduce number of active targets for SC