Bugzilla – Bug 1029
Server should send STREAMINFO header with FLAC stream
Last modified: 2008-08-18 10:53:01 UTC
Richard, it seems like there's little harm in sending the STREAMINFO to the player. I know you've tried this to get FLAC working with Softsqueeze. Care to commit your patch?
Richard, can you try changing FLAC.pm line 152 to: $tags->{'OFFSET'} = 0; # the header info is an important part of the file. don't skip it. # $flac- >{'startAudioData'}; and see if this resolves your issue. Since the flac info headers are a valid part of the flac bitstream (and all decoders can interpret them) we should stream them out.
Dean, you've already found my patch! This does not really solve the problem with Softsqueeze. This will work if you play the track normally, but not if you use cue sheets, or fwd/rew through the stream. If the STREAMINFO was append to all the start of all streams, even if you play from the middle of a flac that would work for me, but I am not sure it is the right thing to do. And I don't have a patch for that yet. Comments?
Feel free to commit that patch. Would like vidur to comment on sending streaminfo on flac stream fragments. I wonder if we should send this metadata as part of the play command or if it should be inband. I'm concerned about whether we should be slicing and dicing FLAC streams.... Why not?