Bugzilla – Bug 10278
exit search jumps back to home menu
Last modified: 2009-10-05 14:31:35 UTC
When browsing the Player UI (SB3/TP/Boom) drill down to Music Library > Search > Artist / Album: on left exit of that menu I get jumped back to Now Playing, not M.L.>Search as expected
Did the screensaver kick in while you were waiting for the search results? What screensaver are you using?
I turned all screen savers to none Andy points out this is how the logic flow is 'supposed' to work. see http://wiki.slimdevices.com/index.php/UserInterfaceHierarchy Dean: I propose we change the flow, so this error does not occur any more.
Andy thinks this is a bug, Triode your thoughts?
There's explicit code in S:B:Search to pop all modes and push into the home mode when you exit left from search. This has been there since revision 8848, but this just changed the original implementaton in revision 3082 which talks about wanting to get back to the home menu from search. I think these special cases can go, but we need to consider what happens when you get to the mode from the search button as well as via browsing the menus.
Shouldn't it just pop back to the previous menu?
Can't see why not - but Vidur put something in revision 3082 to do something differnt.... Easy to remove it.
Dean: any idea why Search behaves differently from other menus?
Not really. Could be due to the search button on the remote, but it sounds broken to me.
Fixed in change 24517.
Oops, that broke other stuff, we'll have to think more about how to properly fix this.
This is a holdover from when Search was a top level menu item. The original design was to exit from a seach and go back to the top, rather then having to step back through the artist/album/track selection. The assumption being that the user no longer wanted to do a search. With Search being a sub of Music Library, it's clearly wrong now. Popping should have been correct. What specific "other stuff" broke with the original change?
The one case Triode found was this: Browse into Music Library a ways. Press search button. You now can't back up to the home menu.
The problem is that there are multiple points of entry. popMode is right when navigating, but due to the search button, you can get directly into the search menus. With the new location of Search, we are no longer jumping to the same menu point in the hash (it assumes top level unless specified) This is one possible solution.. Index: Common.pm =================================================================== --- Common.pm (revision 24113) +++ Common.pm (working copy) @@ -691,7 +691,7 @@ } elsif (mode($client) ne 'search') { - Slim::Buttons::Home::jumpToMenu($client, "SEARCH"); + Slim::Buttons::Home::jumpToMenu($client,"SEARCH", "-BROWSE_MUSIC"); $client->update(); } Index: Search.pm =================================================================== --- Search.pm (revision 24113) +++ Search.pm (working copy) @@ -122,13 +122,12 @@ $exitType = uc($exitType); if ($exitType eq 'LEFT') { - my $oldlines = $client->curLines(); + if ($client->curDepth() ne "") { - Slim::Buttons::Home::jump($client, 'SEARCH'); - while (Slim::Buttons::Common::popMode($client, 1)) {}; - Slim::Buttons::Common::pushMode($client, 'home'); + $client->curDepth(Slim::Buttons::Home::getLastDepth($client)); + } - $client->pushRight($oldlines, $client->curLines()); + Slim::Buttons::Common::popModeRight($client); } elsif ($exitType eq 'RIGHT') {
KDF, can you take this one?
no problem. I'll have to go back through testing so hope I have a bit of time.
fixed in change 27016 for the 7.4 trunk. Search can enter via browsedb or search button. While in the search menu, pressing search again will step through the search options when entered from either method. please reopen if there are issues.
This bug has been marked as fixed in the 7.4.0 release version of SqueezeBox Server! * SqueezeCenter: 28672 * Squeezebox 2 and 3: 130 * Transporter: 80 * Receiver: 65 * Boom: 50 * Controller: 7790 * Radio: 7790 Please see the Release Notes for all the details: http://wiki.slimdevices.com/index.php/Release_Notes If you haven't already, please download and install the new version from http://www.logitechsqueezebox.com/support/download-squeezebox-server.html If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.