Bug 10274 – title bar in NowPlaying often reflects incorrect power state

Bug 10274 - title bar in NowPlaying often reflects incorrect power state

Summary:

title bar in NowPlaying often reflects incorrect power state

Status:	RESOLVED INVALID

Product:	SqueezePlay
Classification:	Unclassified
Component:	Now Playing
Version:	unspecified
Platform:	PC Other

Importance:	P1 normal (vote)
Target Milestone:	7.4.0
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-12-10 12:18 UTC by Ben Klaas
Modified:	2009-09-08 09:31 UTC (History)
CC List:	4 users (show)

See Also:
Category:	---

Attachments
patch to fix problem of not being able to distinguish power off versus no data on power state (1014 bytes, patch) 2008-12-10 12:18 UTC, Ben Klaas	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Klaas 2008-12-10 12:18:43 UTC

Created attachment 4413 [details]
patch to fix problem of not being able to distinguish power off versus no data on power state

the root of this is that I believe there are times when the serverstatus message is not sending the power state of the player back in the data. In these cases, it's not possible for the isPowerOn() method to distinguish between "off" and "no data".

I can effectively workaround this issue by changing the player object's self.info.power from a true/false boolean to a 0/1 numeric and then have a little extra logic in the isPowerOn() method.

attaching patch for review, assigning to Richard.

Comment 1 Ben Klaas 2008-12-10 12:24:24 UTC

just an fyi on this bug-- I've seen the smoke tests fail because of this issue from time to time

Comment 2 James Richardson 2008-12-19 08:02:42 UTC

Changing target to next release

Comment 3 James Richardson 2009-02-10 08:51:40 UTC

Ben: is bug 10893 a dupe of this bug?  I haven't seen this error in SC 7.3.3.  Only on SN

Andy did a fix on test.sn that may apply here as well.

Comment 4 James Richardson 2009-02-10 12:27:55 UTC

Answered my own question, I still see the SBC display 'OFF' on the Now Playing screen on test.sn

Comment 5 Chris Owens 2009-03-16 09:43:13 UTC

We are now planning to make a 7.3.3 release.  Please review your bugs (all marked open against 7.3.3) to see if they can be fixed in the next few weeks, or if they should be retargeted for 7.4 or future.

Thanks!

Comment 6 Chris Owens 2009-03-30 17:19:41 UTC

Since there's now a planned 7.3.3 release, bugs which won't make the cut-off are being moved to the next target out.  If you feel that this bug needs to be addressed more (or less) urgently than the 7.4 release, please cc chris@slimdevices.com and leave a comment in the bug to that effect so we can review it.

Thanks.

Comment 7 Blackketter Dean 2009-07-22 08:39:49 UTC

Moving to the product SqueezePlay because this bug appears to apply to any player based on that application code.  Feel free to move it back if it's specific to the single original product.

Comment 8 Wadzinski Tom 2009-07-30 05:19:03 UTC

relates to 12713, but must work for non-local devices also

Comment 9 Wadzinski Tom 2009-08-14 11:43:07 UTC

Ben,  did you say that in the new look/feel that the power state would not be 
displayed anymore on NP?

Comment 10 Ben Klaas 2009-08-24 12:10:43 UTC

I don't believe this bug is valid any more because the new NP spec does not call for power state to be displayed in the title bar