Bug 10165 - Stream connection failure when synced can lead to invalid state
: Stream connection failure when synced can lead to invalid state
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 7.3.0
: All All
: P2 normal (vote)
: 7.x
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-28 00:42 UTC by Alan Young
Modified: 2009-09-08 09:13 UTC (History)
0 users

See Also:
Category: ---


Attachments
proposed patch (1.27 KB, patch)
2008-11-28 00:56 UTC, Alan Young
Details | Diff
proposed patch 2 (1.52 KB, patch)
2008-11-28 01:17 UTC, Alan Young
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2008-11-28 00:42:42 UTC
If one out of a set of more than one active synced players gets a connection failure to the stream source (either local or remote), and at least one of the players succeeds in connecting, then StreamingController can get into an invalid state. Automatic track advance will also fail in this case.

Typical log messages are:
[08-11-27 10:33:33.1601] Slim::Player::StreamingController::_BadState (317) 00:04:20:06:0b:6f: event StatusHeartbeat received while in invalid state WAITING_TO_SYNC-TRACKWAIT
[08-11-27 10:33:33.1611] Slim::Player::StreamingController::_eventAction (288) 00:04:20:06:0b:6f:  StatusHeartbeat with action Slim::Player::StreamingController::_BadState resulted in invalid state WAITING_TO_SYNC-TRACKWAIT
Comment 1 Alan Young 2008-11-28 00:56:51 UTC
Created attachment 4360 [details]
proposed patch
Comment 2 Alan Young 2008-11-28 01:15:16 UTC
Dean, the scope of this patch is pretty isolated, only covering streaming-failed cases.  It also only covers the cases when starting to stream from stopped, which may not have been the case you hit. Can you confirm that there were no relevant log messages before the two in the description above?
Comment 3 Alan Young 2008-11-28 01:17:24 UTC
Created attachment 4361 [details]
proposed patch 2
Comment 4 Alan Young 2008-11-28 01:22:17 UTC
Dean, the second patch is more comprehensive, and also covers the case when a connection failure occurs for the 'next' stream, when paying out the current stream. The side-effect is that the current stream may be stopped somewhere in the last 10 seconds. I'll try to see if I can come up with a way of letting that stream play out in these circumstances.
Comment 5 Blackketter Dean 2008-11-28 07:42:54 UTC
Yeah, there were no other relevant log messages before those pairs.

I don't quite understand the problem or the patch.   Does it recover from this failure or just stop?

Comment 6 Alan Young 2008-11-28 08:02:36 UTC
Without the patch it just stalls. With the patch it will try to move on, possibly cutting up to 10s off the end of the previous track.

But I still do not understand why there was not a preceding error message.
Comment 7 Alan Young 2008-12-04 15:00:34 UTC
Change 24206
Comment 8 James Richardson 2008-12-15 12:10:14 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 9 Chris Owens 2009-07-31 10:32:50 UTC
Reduce number of active targets for SC