Bug 10164 – MusicIP item should drill down into trackinfo instead of songinfo

Bug 10164 - MusicIP item should drill down into trackinfo instead of songinfo

Summary:

MusicIP item should drill down into trackinfo instead of songinfo

Status:	CLOSED FIXED

Product:	SB Controller
Classification:	Unclassified
Component:	Browser
Version:	unspecified
Platform:	PC Windows XP

Importance:	-- normal (vote)
Target Milestone:	7.3.1
Assigned To:	Michael Herger

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-11-28 00:42 UTC by Michael Herger
Modified:	2008-12-22 11:36 UTC (History)
CC List:	6 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2008-11-28 00:42:34 UTC

MusicMagic/Plugin.pm around line 1002 uses songinfo instead of the trackinfo menu. The songinfo's menu is deprecated in favour of trackinfo.

Comment 1 KDF 2008-11-29 16:38:13 UTC

simple (tests out ok too): 

Index: Slim/Plugin/MusicMagic/Plugin.pm
===================================================================
--- Slim/Plugin/MusicMagic/Plugin.pm	(revision 24155)
+++ Slim/Plugin/MusicMagic/Plugin.pm	(working copy)
@@ -988,7 +988,7 @@
 		my $base = {
 			actions => {
 				go => {
-					cmd => ['songinfo'],
+					cmd => ['trackinfo','items'],
 					params => {
 						menu => 'nowhere',
 					},

Comment 2 Michael Herger 2008-12-01 12:04:42 UTC

thanks kdf - applied in change 24171

Comment 3 Ross Levine 2008-12-19 14:59:16 UTC

How can QA verify this?

Comment 4 Michael Herger 2008-12-19 15:27:14 UTC

you could eg. look what command is sent by enabling network.cometd. Not very elegant...

Comment 5 KDF 2008-12-19 16:11:41 UTC

Also, the items displayed on the controller when you go into the track info is different.  The songinfo has a list of tag data, while the trackinfo does a list of some data, with a "more info" item to get to other less important metadata.

Comment 6 Ross Levine 2008-12-19 17:24:58 UTC

Does this mean that "more info" indicates trackinfo and not songinfo?

Comment 7 Ben Klaas 2008-12-22 07:28:07 UTC

Exactly right. Also, if there are any "on foo" items (on pandora, on rhapsody, etc.), that comes from trackinfo. You see those things, the bug is verified.

Comment 8 James Richardson 2008-12-22 11:36:50 UTC

This bug has been fixed in the 7.3.1 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.