Bugzilla – Bug 10132
Extension Installer: version check fails
Last modified: 2009-09-08 09:20:33 UTC
7.4 is not considere larger than 7.3+, though larger than 7+ [08-11-25 16:39:24.6311] Slim::Plugin::Extensions::Plugin::_parseXML (291) searching http://erlandplugins.googlecode.com/svn/repository/trunk/latest.xml for type: plugin target: mac version: 7.4 [08-11-25 16:39:24.6316] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry TrackStat does not match, bad target version [7.4 outside 7.1.0, 7.3+] [08-11-25 16:39:24.6321] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry CustomBrowse does not match, bad target version [7.4 outside 7.1.0, 7.3+] [08-11-25 16:39:24.6325] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry CustomScan does not match, bad target version [7.4 outside 7.1.0, 7.3+] [08-11-25 16:39:24.6330] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry CustomSkip does not match, bad target version [7.4 outside 7.1.0, 7.3+] [08-11-25 16:39:24.6334] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry DynamicPlayList does not match, bad target version [7.4 outside 7.2.0, 7.3+] [08-11-25 16:39:24.6338] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry DatabaseQuery does not match, bad target version [7.4 outside 7.1.0, 7.3+] [08-11-25 16:39:24.6342] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry MultiLibrary does not match, bad target version [7.4 outside 7.1.0, 7.3+] [08-11-25 16:39:24.6347] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry SQLPlayList does not match, bad target version [7.4 outside 7.1.0, 7.3+] [08-11-25 16:39:24.6351] Slim::Plugin::Extensions::Plugin::_parseXML (306) entry TitleSwitcher does not match, bad target version [7.4 outside 7.1.0, 7.3+] [08-11-25 16:39:24.6354] Slim::Plugin::Extensions::Plugin::_parseXML (347) found 0 extensions
It uses Slim::Utils::Versions->checkVersion, so is this a fault in the main SC code?
Hum so S:U:Versions doesn't seem to work for this case? print "vers 7.4: " . Slim::Utils::Versions->checkVersion('7.4', '7.1.0,', '7.3+') . "\n"; print "vers 7.3: " . Slim::Utils::Versions->checkVersion('7.3', '7.1.0,', '7.3+') . "\n"; vers 7.4: 0 vers 7.3: 1 Don't have time to look at but looks like 7.3+ doesn't actually work if the comparison is against something larger than 7.3
Actually looking at https://developer.mozilla.org/en/Toolkit_version_format, which is what Dan referenced, I'm not convinved 7.3+ is supposed to be greater than 7.4 - so its probably working correctly?
No need to fix this for 7.3 as it only influences settings larger than 7.3. BTW: the check seemed to be working in PluginManager, where the same function is used. Will see what difference there is.
I think 7.3+ is < 7.4 by design. I'm not sure whether 7.3+ is considered 7.3.*? Setting a maximum value which is open doesn't make sense anyway. In this case * should be used.
Reduce number of active targets for SC