Bug 10115 - style conflicts between windowSpec with icon and menuStyle 'album'
: style conflicts between windowSpec with icon and menuStyle 'album'
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: PC Other
: -- normal (vote)
: 7.3
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-24 08:30 UTC by Ben Klaas
Modified: 2008-12-15 12:09 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments
bad layout when title has icon and menu have icons (65.90 KB, image/png)
2008-11-24 08:30 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2008-11-24 08:30:34 UTC
Created attachment 4325 [details]
bad layout when title has icon and menu have icons

what's happening is that the window is being styled based on things from the item that's creating the window. so, if the window is being created from an item with an icon, jive.SlimBrowser styles the title bar with an icon. If the menu also has icons, there's only room for 3 per screen

...and the window is spec'ed before the menu style is decided upon. Unforutnately this makes the window spec for Internet Radio->Local (where you don't want the icon in the title bar) identical to Music Library->Albums->Some Album (where you do want the icon in the title bar).


would be nice to fix this for 7.3
Comment 1 Ben Klaas 2008-11-24 13:04:37 UTC
fixed on jive-side, r3432

Do not allow a window to have titleStyle of 'albumtitle' when the underlying menu style is 'albummenu'. Both title and menu can't contain icons if 4 items are going to fit on the controller screen.
Comment 2 James Richardson 2008-12-15 12:09:58 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.