Bugzilla – Bug 10094
Include SC download screen if PIN not entered
Last modified: 2009-09-08 09:26:33 UTC
Moving an e-mail thread to Bugzilla: I tried [the SN sign-up process] today and discovered that without a PIN, a user is unceremoniously dumped into the SN home page. I haven't yet tested the process with a PIN as I don't have a player handy. ... The majority of users do use SC and if a user goes to sign up before they have set up their player, we need to make that the easiest path to take. ... the "no pin" option should take them to download SC the same as with the PIN.
It's a simple change (reversal of change 4986), but we need a decision Index: /Users/mh/Documents/workspace/SN/lib/SDI/SqueezeNetwork/Controller/User/Register.pm =================================================================== --- /Users/mh/Documents/workspace/SN/lib/SDI/SqueezeNetwork/Controller/User/Register.pm (revision 5094) +++ /Users/mh/Documents/workspace/SN/lib/SDI/SqueezeNetwork/Controller/User/Register.pm (working copy) @@ -150,13 +150,8 @@ $c->forward( '/user/saveState', [ $state ] ); - if ( $state->{player_pin} ) { - $c->res->redirect( '/user/download' ); - } - else { - # go directly to user's home if he didn't provide a player pin - $c->res->redirect( '/' ); - } + $c->res->redirect( '/user/download' ); + return; }
weldon: we need an opinion on this asap.
I need some clarification on why the no-PIN case has to be supported at all. Dean explained this a month or two ago, and it made sense at the time, but my understanding is that it was an edge case. Based on my current understanding, not entering a PIN means no device is linked to the network. Therefore all the "congratulations! you're ready to go!" type language on the next two screens is completely misleading. In fact the user really can't do anything at all at this point except download squeezecenter. Once a user is logged in to SN, there is a "download squeezecenter" link at the top-right of the screen. Granted, this isn't nearly as graceful as a success screen, but given that this was an edge case, it seemed a lot of work to design a completely different success screen. Can someone explain the state of the user/player in the case where they create an account with no PIN? Why does this need to be supported? Given that understanding, resolving this should be pretty simple.
So here is the resolution I worked out with Dean today via phone. Not perfect but probably far better than the existing version (which to be fair is being magnified, I think, by a large number of people testing this feature without having a PIN available for the test server). Needed changes: 1. If the user does not enter a PIN, bring them to the "Download SqueezeCenter?" screen (same as if they enter a PIN) 2. On the non-PIN version of the "Download SqueezeCenter?" page, change the top-left messaging/copy from "Your Squeezebox is now set up to play internet radio and music services." to "Your SqueezeNetwork account has been created." 3. On the non-PIN version of the "Download SqueezeCenter?" page, make the "I don't need SqueezeCenter right now" button link to the logged-in SqueezeNetwork home page (i.e. bypass the "congratulations!" screen. This should hopefully go a long way toward resolving user confusion.
Heh... poor Europen customers won't be less confused by the English only text ;-)
The only text that should change is: Your Squeezebox is now set up to play internet radio and music services. to Your SqueezeNetwork account has been created. If we don't have the latter in all languages, leave it as the former in the right language until the translations come through.
Ok, that's revision 5168 then.
This bug has been fixed in the latest release of SqueezeNetwork! If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.