Bug 10085 - Track advance sometimes fails for SB1s
: Track advance sometimes fails for SB1s
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Streaming From SlimServer
: 7.3.0
: All Debian Linux
: P1 normal (vote)
: 7.x
Assigned To: Alan Young
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-20 08:43 UTC by Alan Young
Modified: 2009-07-31 10:32 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2008-11-20 08:43:36 UTC
A race condition connected with the timer for Web::HTTP:tryStreamingLater() can, in the callback for an old streaming connection, discard the timer for a new connection. Thus no streaming occurs if it had not been possible to select for read on the input stream, which could be the case when transcoding and on Windows where the pipeline_reader socket is set-up asynchronously.

This should only happen: on Windows, using Transcoding and (I think) with SB1s.
Comment 1 Alan Young 2008-11-20 08:53:28 UTC
Change 23983.
Comment 2 Craig Garnett 2008-11-22 01:53:48 UTC
Since installing build 24011 I've had 2 SB1s and 1 SB2 on Random mix over night and they're all still player after 8 hours!

Craig

Comment 3 Craig Garnett 2008-11-24 08:07:03 UTC
I had to stop 2 of the players but 1 SB1 ran all weekend without a hiccup so I think we can call this fixed.

Thanks

Craig

Comment 4 Craig Garnett 2008-11-24 08:39:45 UTC
Just to spoil things, I've just noticed that I'm not getting gapless playback on the SB1s but the same tracks play seamlessly on the Transporter.

Craig

Comment 5 Alan Young 2008-11-24 08:43:05 UTC
You only get (pseudo-)gapless playback on SB1s for MP3s and when not synced. 
Comment 6 Craig Garnett 2008-11-24 08:55:42 UTC
Well these are flacs and the player's not synced.
Maybe I've just never noticed before. It's a consequence of playing my entire Pink Floyd collection all weekend to give it a good test :-)

Craig

Comment 7 Alan Young 2008-11-24 09:23:45 UTC
Actually, SC7.2 used to do pseudo-gapless for SB1s for wav but the algorithm was not safe and could screw up horribly if the following wav did not have the same properties (endianness/sample-rate/...) as the preceeding one.
Comment 8 Craig Garnett 2008-11-24 09:53:32 UTC
Ok that explains it. Is it worth me raising a bug/enhancement request or is it not possible with 7.3's streaming?

Craig
Comment 9 Alan Young 2008-11-25 01:35:13 UTC
You could file an enhancement request but it would be pretty difficult to implement properly. I have just looked at the code and there would need to be quite a bit of refactoring to get it right. I'm not sure that we would do that for SB1s any more. Sorry.
Comment 10 James Richardson 2008-12-15 12:09:50 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 11 Chris Owens 2009-07-31 10:32:16 UTC
Reduce number of active targets for SC