Bug 1005 - unset tags shouldn't stomp on tags that are set
: unset tags shouldn't stomp on tags that are set
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Tagging
: 6.0.0
: All All
: P2 minor (vote)
: ---
Assigned To: Vidur Apparao
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-03-09 19:02 UTC by michael
Modified: 2008-12-15 11:57 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
proposed fix (540 bytes, patch)
2005-04-22 17:12 UTC, Vidur Apparao
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description michael 2005-03-09 19:02:33 UTC
I have a collection of files from a particular artist.  One of the files didn't
have the sort order tag (TSOP) set, and all the others had it set properly. 
Ideally, the odd song should be retagged, but when something like this does come
up, the song without out the tag set shouldn't affect this field at all.
Currently slimserver will set a default value when the sort order tag is empty,
which makes sense, except that currently that default value will stomp on a
correct value entered from another track.  I don't have a problem with last
write wins, but unset tags shouldn't take precedence over set ones. 
I don't know which other tags may be affected in a similar way.
Comment 1 Blackketter Dean 2005-04-20 14:15:38 UTC
Vidur has a fix for this.  Considering for 6.0.2 if it's not complicated.
Comment 2 Vidur Apparao 2005-04-22 17:12:19 UTC
Created attachment 450 [details]
proposed fix

The existence of a TSOP when we first see the artist is the one that persists.
The patch changes the behavior to last specified TSOP. Michael, can you confirm
this works for you?
Comment 3 Vidur Apparao 2005-04-24 11:11:00 UTC
Fixed on trunk (change 3058) and branch (change 3059). Michael, please confirm
with a Wipe Cache.
Comment 4 michael 2005-04-24 14:44:07 UTC
Much better.  Thanks!
Comment 5 James Richardson 2008-12-15 11:57:15 UTC
This bug has been fixed in the latest release of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.