Bug 10025 - Pipline and select needs improvement.
: Pipline and select needs improvement.
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Transcoding
: 7.3.0
: All All
: P3 normal (vote)
: ---
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-15 08:53 UTC by Alan Young
Modified: 2008-11-20 09:02 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2008-11-15 08:53:52 UTC
Pipeline should manage its own source stream select and not have streaming delegate its select.
Comment 1 Alan Young 2008-11-20 09:02:01 UTC
On reflection, this is not really an issue. The streaming code selects on the "pipeline_reader" socket, effectively the output of the pipeline (which makes sense), not the source, as I had thought. Having another select for the source may slightly speed things up at the start but will not really make much difference. The streaming code does not rely on the select - it just uses it as an optimization, and still polls every 400ms.

The concern that triode had, that the streaming code would not retry fast enough to keep the player fed when transcoding to PCM (WAV) because of small pipe buffers, is not valid because this is resolved by selecting the pipe.