Bug 10005 - Web interface does not remember last player used
: Web interface does not remember last player used
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.3.0
: PC Other
: -- major (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-11-14 08:35 UTC by Ben Sandee
Modified: 2009-07-31 10:32 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Sandee 2008-11-14 08:35:54 UTC
For the past several days' builds the web interface does not appear to be remembering the last player used (FF 3.0, Ubuntu 8.10 client and Debian Lenny server).  For me it always goes to the last player in the list, but this could be due to mac address ordering.  In my case, the last player is a SliMP3.

Running 7.3~23931 from .deb logitech repo.
Comment 1 James Richardson 2008-11-14 08:46:51 UTC
QA has seen this behavior as well.  
Comment 2 Michael Herger 2008-11-14 09:55:47 UTC
Please make sure you clear your browser's cache. I've broken this earlier this week in an attempt to fix bug 9947, but reverted again yesterday.
Comment 3 Ben Sandee 2008-11-14 10:01:30 UTC
Clearing the cache was the first thing I tried this morning when I updated from the deb repo.  To be absolutely sure, I just tried with a fresh Firefox profile and I see the same behavior.
Comment 4 KDF 2008-11-14 11:23:14 UTC
Michael, this may be due to my fix for bug 9830 at change 23859.  Some of default skin's handling is from the root which gets blocked from cookie handling becuase it doesn't match the m/html$/ test.

this may be better, and still avoid unnecessary cookie processing:

Index: C:/slim/7.3/server/Slim/Web/HTTP.pm
===================================================================
--- C:/slim/7.3/server/Slim/Web/HTTP.pm	(revision 23926)
+++ C:/slim/7.3/server/Slim/Web/HTTP.pm	(working copy)
@@ -562,8 +562,8 @@
 			$request->push_header("X-Slim-CSRF",$csrfAuth);
 		}
 		
-		# Read cookie(s) for html files only
-		if ($path && $path =~ m/html$/i) {
+		# Dont' process cookies for graphics
+		if ($path && $path !~ m/(gif|png)$/i) {
 			if ( my $cookie = $request->header('Cookie') ) {
 				if ( hasCookieXS() ) {
 					# Parsing cookies this way is about 8x faster than using CGI::Cookie directly

Comment 5 Ben Sandee 2008-11-14 11:30:54 UTC
Thanks kdf, that seems to fix it!
Comment 6 KDF 2008-11-14 16:08:41 UTC
change 23935
Comment 7 James Richardson 2008-12-15 12:37:12 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 8 Chris Owens 2009-07-31 10:32:03 UTC
Reduce number of active targets for SC